Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

launch: add more config options #752

Merged
merged 2 commits into from
Sep 2, 2024
Merged

launch: add more config options #752

merged 2 commits into from
Sep 2, 2024

Conversation

BrettMayson
Copy link
Owner

@BrettMayson BrettMayson commented Sep 2, 2024

Closes #735 , Alternative to #739, I don't know why we didn't just think of this earlier

@BrettMayson BrettMayson changed the title luanch: add more config options launch: add more config options Sep 2, 2024
Copy link

codecov bot commented Sep 2, 2024

Codecov Report

Attention: Patch coverage is 25.92593% with 40 lines in your changes missing coverage. Please review.

Project coverage is 65.3%. Comparing base (9b995b3) to head (4738e06).
Report is 2 commits behind head on main.

Files with missing lines Patch % Lines
libs/common/src/config/project/hemtt/launch.rs 14.2% 24 Missing ⚠️
bin/src/commands/launch/mod.rs 5.8% 16 Missing ⚠️
Additional details and impacted files
Files with missing lines Coverage Δ
bin/src/commands/dev.rs 88.0% <100.0%> (+0.5%) ⬆️
bin/src/commands/launch/mod.rs 17.6% <5.8%> (-2.3%) ⬇️
libs/common/src/config/project/hemtt/launch.rs 63.3% <14.2%> (-17.0%) ⬇️

... and 3 files with indirect coverage changes

@BrettMayson BrettMayson merged commit 06dd402 into main Sep 2, 2024
19 checks passed
@BrettMayson BrettMayson deleted the more_launch_options branch September 2, 2024 16:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Feature Request] Add ability to pass CLI params to hemtt executable for launch presets
1 participant