Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

parse: fix // inside single quote strings #740

Merged
merged 1 commit into from
Aug 10, 2024

Conversation

PabstMirror
Copy link
Collaborator

e.g. url inside single quote string

error[SPE1]: invalid token
1 │ _ctrl htmlLoad 'https://zombo.com/';
  │                      ^ invalid token

the // was treated as a comment and the rest of line was cutoff (so just 'https:)

I am not positive on my change to parsing logic and changes should be carefully looked it,
but it seems to pass all tests

Copy link

codecov bot commented Aug 9, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 68.8%. Comparing base (21b2b2e) to head (8023a3d).

Additional details and impacted files
Files Coverage Δ
libs/preprocessor/src/parse/mod.rs 94.6% <100.0%> (+0.2%) ⬆️

... and 6 files with indirect coverage changes

@BrettMayson BrettMayson merged commit 7bd9fa2 into BrettMayson:main Aug 10, 2024
23 of 31 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants