Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

sqf: fix serilizing empty code #756

Merged
merged 1 commit into from
Sep 2, 2024
Merged

sqf: fix serilizing empty code #756

merged 1 commit into from
Sep 2, 2024

Conversation

PabstMirror
Copy link
Collaborator

maybe alt to #754
I think we still need #748 for extracting vars that are single chars

cba/ace builds using this seem to work fine, but I don't have full confidence

Copy link

codecov bot commented Sep 2, 2024

Codecov Report

Attention: Patch coverage is 66.66667% with 1 line in your changes missing coverage. Please review.

Project coverage is 65.2%. Comparing base (0981a02) to head (b7d9d96).
Report is 4 commits behind head on main.

Files with missing lines Patch % Lines
libs/sqf/src/compiler/mod.rs 66.6% 1 Missing ⚠️
Additional details and impacted files
Files with missing lines Coverage Δ
libs/sqf/src/compiler/mod.rs 97.2% <66.6%> (-0.5%) ⬇️

... and 1 file with indirect coverage changes

@BrettMayson
Copy link
Owner

Using this branch I don't see any of the issues that #736 fixed for us

@BrettMayson BrettMayson merged commit 5100597 into main Sep 2, 2024
26 of 31 checks passed
@BrettMayson BrettMayson deleted the fixCodeSerial branch September 2, 2024 20:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants