chore: update for 2023 #29
Conversation
| - uses: actions/checkout@v3 | ||
| with: | ||
| clean: false #this is to avoid permissions on self-hosted runner | ||
| - name: Pre-check dirty dirs in self-hosted |
There was a problem hiding this comment.
lets do this on another PR, but our self-hosted runners are now ephemeral and all of this checking/cleaning of files and directories can be removed
There was a problem hiding this comment.
Sounds great! Will add another PR to address this
| name: gcr.io/jupyterhub-docker-images/jupyterhub-scipy | ||
| tag: phys1600-spring2020 | ||
| name: gcr.io/jupyterhub-docker-images/mpa2065 | ||
| tag: latest |
There was a problem hiding this comment.
best to use another tag that is more stable than latest, but fine for now
| @@ -67,12 +67,6 @@ module "shared-nfs" { | |||
|
|
|||
| locals { | |||
| helm_release_wait_condition = length(kubernetes_secret.tls_secret) > 0 ? kubernetes_secret.tls_secret[0].metadata[0].name : kubernetes_namespace.jhub.metadata[0].name | |||
There was a problem hiding this comment.
hm - why did this nfs code change? We also could check this deployment, which is not part of the tests
There was a problem hiding this comment.
Maybe I got rid of this for testing and somehow forgot to add it back? I will add it back and rerun the tests
There was a problem hiding this comment.
Oh @mirestrepo actually tflint complained that this is declared by unused. It was used in line 220 of this file, which was commented out, so I just removed it. Should be safe to leave out then?
What was updated: