Clicking label not working as expected

[plribeiro3000]

Hi. The new version @LostCrew release handles clicks on the label. But im facing a weird behavior, if the label is on the right side, it does not change the button, but does trigger the event and everything else work as expected.

I have a simple example on fiddle : http://jsfiddle.net/plribeiro3000/aL835/1/

[plribeiro3000]

I have updated the code to show something i have noticed: http://jsfiddle.net/plribeiro3000/aL835/3/

If you look at the console you will the event being triggered twice. Is this behavior expected?

[LostCrew]

good morning @plribeiro3000,
thank your for the detailed case. can you update the jsfiddle with the version 3.0.1? you have to copy/paste it since it's been released yesterday and not available on cdn yet.

[plribeiro3000]

Good morning @LostCrew !
Im already using the last version. I have uploaded it to a server and referenced it from there. =)

[plribeiro3000]

The link is : http://cdn2.plribeiro3000.com.br/bootstrap-switch.js =)

[plribeiro3000]

I found that https://github.com/nostalgiaz/bootstrap-switch/blob/master/src/coffee/bootstrap-switch.coffee#L236 is triggering the event again if the input is a radio and the event did not turned the switch on.

Is that the behavior expected? or should it act like normal radio buttons?

[plribeiro3000]

My bad, it acts like a normal radio button by doing nothing if you click on a already selected option.
But it seems a bit weird when you are working with switchs, shouldn't it always change its state and set the other options the other state?

[LostCrew]

@plribeiro3000 can you update the bootstrap switch source of the jsfiddle according to the latest develop branch changes? i made a couple of optimizations and they might have implicitly solved this issue. thanks.

[plribeiro3000]

I have updated the source at plribeiro3000.com.br, but just in case i have update the jsfiddle as well.

New link : http://jsfiddle.net/plribeiro3000/aL835/6/

But the behavior still exists.

[psychonelo]

After hours of debugging JavaScript in firebug, I found that I can fix this by removing the 'for' attribute from the label:

var checkbox = $("<input type='checkbox' id='MyCheckbox'>").prependTo( $("body") );
checkbox.bootstrapSwitch();
var bootstrapSwitch = checkbox.data('bootstrap-switch');
bootstrapSwitch.$label.removeAttr("for");

Clicking a label with attribute for="MyCheckbox" will be handled by Firefox. Removing removing the 'for' attribute from the label stops Firefox from changing the checkbox value again.

[LostCrew]

@psychonelo @plribeiro3000 thank you very much for the collaboration. feel free to give the updated develop branch a ride and tell me.