Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bump api versions #28

Open
wants to merge 6 commits into
base: 8.0.x-1.12.2
Choose a base branch
from

Conversation

AEnterprise
Copy link
Member

between 7.99.4 and 7.99.5 there where api changes but the versions never got bumped

also not sure if the 'owner' of an api can be another api, i beleive this should be a mod as all apis are loaded at the same time so they don't exist yet

@AlexIIL
Copy link
Member

AlexIIL commented Jul 7, 2017

This won't be happening until we get out of alpha

@AlexIIL AlexIIL closed this Jul 7, 2017
@AlexIIL AlexIIL reopened this Jul 7, 2017
@AlexIIL
Copy link
Member

AlexIIL commented Jul 7, 2017

Is this defiantly everything that's changed since 7.2.x?

@AlexIIL
Copy link
Member

AlexIIL commented Jul 7, 2017

Oh right sorry, this only bumps things from 7.99.4 - we really need to bump everything that's changed since 7.2.x, or even 7.1.x.

@AlexIIL AlexIIL closed this Aug 18, 2019
@AlexIIL
Copy link
Member

AlexIIL commented Aug 18, 2019

Dammit there's no "re-target button here to retarget to 8.0.x-1.12.2 :/

@AlexIIL
Copy link
Member

AlexIIL commented Aug 18, 2019

(Although at this point I think I might have missed the window for changing API versions? I should really have merged this immediately as nothing else will change now in 1.12.2)

@AEnterprise
Copy link
Member Author

@AlexIIL you can retarget with the edit button at the next to the name normally

@AlexIIL
Copy link
Member

AlexIIL commented Aug 18, 2019

Github only seems to let me edit the target branch if the PR is still open, so I'll re-create the old branch temporarily.

@AlexIIL AlexIIL reopened this Aug 18, 2019
@AlexIIL AlexIIL changed the base branch from 8.0.x to 8.0.x-1.12.2 August 18, 2019 16:42
@AlexIIL
Copy link
Member

AlexIIL commented Aug 18, 2019

Ok, thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants