-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make GPT Crawler a CLI #38
Conversation
96bdc24
to
9475306
Compare
Thank you for this pull request. |
Hey @databill86! I've commented about your feature request on #43 😉, but TLDR; I like the idea! |
ba8c463
to
f3db53f
Compare
This is awesome @marcelovicentegc! Also just realized that you work at VTEX, awesome, I know Mariano and Geraldo (they are amazing) and I went to VTEX Day last year! To answer your questions: lets definitely setup the workflow process through github actions. I can happily add an NPM_TOKEN to the secrets there. And semantic release is perfect. Also, I recall you saying this was WIP, is it ready for review on your side or worth still waiting on? |
f3db53f
to
5000a21
Compare
How cool, @steve8708! This is awesome! I was at VTEX Day this year ❤️. It's such a great event. I will set up semantic-release + GitHub actions on another PR, since this one is already large, ok? 🤗 And finally, the PR is rebased and good for review 👍 |
🎉 This PR is included in version 1.0.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Make GPT Crawler a CLI
Essentially:
core.ts
: the core methods live heremain.ts
leverages the methods fromcore.ts
to run the service with config filecli.ts
: leverages the methods fromcore.ts
to run the service as a CLIWhat are the next steps?
#56 addresses the aforementioned changes ☝️
I can address all these on different PRs but need your feedback. Let's keep in touch 😉 .
Other changes that are not directly related to the CLI and that I can revert back to what it was or open other PRs:
preinstall
script for automatic playwright setupConfig
interface jsDocs with@example
and@default
decoratorsResolves #37