Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding "Press Back again to exit" in Simulator and Templates #368

Open
codingblazer opened this issue Jan 3, 2017 · 6 comments
Open

Adding "Press Back again to exit" in Simulator and Templates #368

codingblazer opened this issue Jan 3, 2017 · 6 comments

Comments

@codingblazer
Copy link
Contributor

Just like we added Press Back again to exit in Toolkit, we can add this in simulator and Templates also because there are some templates like comprehension which have timer and needs to have this feature.

@m-murad
Copy link
Contributor

m-murad commented Jan 3, 2017

@codingblazer
Adding this feature in simulator and Templates, i don't think that's a good idea. The main purpose of the app is to keep user in the application.

Perhaps you should add this feature to the generated applications.

It's just a suggestion. Lets see what project mentors think.

@codingblazer
Copy link
Contributor Author

@free4murad App already has this feature. When I say Templates, I mean generated applications only. And since simulator is just reflection of these generated apps, we should add in it too.

@m-murad
Copy link
Contributor

m-murad commented Jan 3, 2017

@codingblazer
I know that the app has this feature (It was me who implemented it).

I agree with you that this feature should be implemented in the generated apps. What I feel is, this feature in simulator might be confusing. Thats why I said it's just a suggestion.

@codingblazer
Copy link
Contributor Author

@free4murad Ok. Lets see what mentors think about this.

@opticod
Copy link
Collaborator

opticod commented Feb 8, 2017

@codingblazer You can proceed adding both for the APKs and for the simulator. Also make a separate PR to templates-toolkit repo.
@free4murad, If we add any feature in created APKs, then our simulators should also reflect the same. So looks like adding it.

@codingblazer
Copy link
Contributor Author

@opticod Yeah sure

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants