Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Press Back Again Toast in Simulator #415

Open
wants to merge 1 commit into
base: bug-fixes
Choose a base branch
from
Open

Add Press Back Again Toast in Simulator #415

wants to merge 1 commit into from

Conversation

codingblazer
Copy link
Contributor

@codingblazer codingblazer commented Feb 9, 2017

Fix #368
@opticod Please Review. PR for templates sent too.
I have also handled another case - Earlier on pressing back when navigation drawer was opened caused drawer and app both to close. Now only drawer closes.

Copy link
Collaborator

@opticod opticod left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@codingblazer , your implementation for template repo is fine and merged it, but in this code there are some problems in your implementation.

Like, go to Simulator of Info Template and then click any one of the items in list, and now click back....user is in deadlock state, neither menu back nor navigation back is working here....Please fix this.

@codingblazer
Copy link
Contributor Author

@opticod Changes made !! Please review.

A side note - In Quiz and some templates having navigation bar, if let you open a simulator => Ques 1 appears, now if you open same from navigation bar => Press back => Nothing happens (it looks that bug is still not solved but it is !! (back press killed the duplicate instance of Ques 1)

@opticod
Copy link
Collaborator

opticod commented Sep 1, 2017

Will soon start reviewing and merging the PRs. Thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants