Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bengali language support added #191

Open
wants to merge 1 commit into
base: bug-fixes
Choose a base branch
from
Open

bengali language support added #191

wants to merge 1 commit into from

Conversation

codingblazer
Copy link
Contributor

@codingblazer codingblazer commented Oct 29, 2016 •
edited
Loading

Hey @opticod , I have added the support for Bengali language( #169 ) . Please check it. Thanks.

@opticod
Copy link
Collaborator

opticod commented Nov 1, 2016

Thanks @codingblazer, I will be reviewing the translation and will merge it,

@opticod opticod self-assigned this Nov 1, 2016
opticod
opticod requested changes Nov 27, 2016
View reviewed changes
Copy link
Collaborator

@opticod opticod left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I was checking from the beginning, but there is lots of errors like meanings, punctuations. It seems its just the output from google translator but it requires more human translations. Only NLP will not help here.

I added few error comments from beginnings. There is lot more error. Please correct them.

source-code/app/src/main/res/values-bn/strings.xml
<string name="menu_load_project">সংরক্ষিত প্রকল্প</string>
<string name="menu_settings">সেটিিংস</string>
<string name="menu_drafts">আমার খসড াতে</string>
<string name="menu_how_to">ক্ষকভাবে</string>
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

not correct

source-code/app/src/main/res/values-bn/strings.xml
<string name="menu_drafts">আমার খসড াতে</string>
<string name="menu_how_to">ক্ষকভাবে</string>
<string name="menu_about_us">BuildmLearn সম্পর্কে</string>
<string name="menu_home">বাড ি</string>
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

not correct

source-code/app/src/main/res/values-bn/strings.xml
<string name="buildmlearn_welcome_title">BuildmLearn টুলকিট স্বাগতম</string>

<!-- TODO: Remove or change this placeholder text -->
<string name="buildmlearn_welcome_text">BuildmLearn টুলক্ষকট একটট সহজ-থেবক-েযেহার থপ্রাগ্রামটট েযেহারকারীবের অ্যাক্ষিবকশন উন্নয়বনর থকান জ্ঞান ছাডা থমাোইল অ্যাপস করবত সাহায্য কবর.\n\nটুলকিট বিভিন্ন কার্যকারিতা সঙ্গে মোবাইল অ্যাপ্লিকেশন তৈরি করতে সাহায্য করে এবিং ইনপুট তাদের নিজস্ব বিষয বস্তু শিক্ষকদের পারবেন</string>
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not correct

@opticod opticod removed their assignment Nov 27, 2016
@codingblazer
Copy link
Contributor Author

@opticod I am really sorry for the trouble. Actually I did it with a help of my friend. There was some miscommunication due to which he thought that just words are to be translated. It would be great if you can clarify some of my doubts -

lots of errors like meanings

  1. By "meaning" , are you implying that sentences are not meaningful as in line 15.
    Or
    Are you also implying that inappropriate words are used for given context. If yes , then please refer line no. as a example.

  2. Can you give a one line example where punctuation is wrong so I can tell him exactly which type of punctuation errors are made.

  3. Some words like BuildmLearn , Navigation Drawer , don't have appropriate translation in Bengali. So , should they be translated as -
    a) Navigation - নেভিগেশান
    or
    b) Navigation - Navigation (kept in english version )
    BuildmLearn - BuildmLearn

Please tell if any other type of mistake is being done. I will discuss with him and make changes as soon as possible. Thanks and sorry for trouble.

@opticod
Copy link
Collaborator

opticod commented Nov 28, 2016

  1. By meaning, I imply that as a complete sentence, its verb is not correct and is not making sense.
    As in Line 5 : করুে will be করুন
  2. By punctuation (majority of error) : I mean
    As in Line 15: টুলক্ষকট will be টুলকিট , in some sentences its correct and somewhere its wrong.
    একটট will be একটি .......
  3. If it doesn't have bengali translation, then
  • change that into its bengali form like নেভিগেশান for Navigation
  • keep nouns like BuildmLearn as BuildmLearn only in English.

@opticod opticod force-pushed the bug-fixes branch 2 times, most recently from a3993ce to 6eea6bd Compare January 29, 2017 14:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@opticod opticod opticod requested changes

Assignees
No one assigned
Labels
request changes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@codingblazer @opticod