Initial Uri navigation #23
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This version looks better since the navigation happens in one go. OnNavigatedTo is only called on the one page you are going to and OnNavigatedFrom only happens on the page you are leaving (rather than every page in between). It probably is possible to make these events happen on the in-between pages if that would be the best behaviour.
This new design still won't call OnNavigatedFrom/To etc. events for more than two pages. The new method handles absolute and go back a lot cleaner. The end visual result doesn't look as nice though.
Fixes #22
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR introduces a rough first attempt at URI navigation. There are inconsistencies on when events trigger and what parameters get passed at each stage, but the end results of the navigation are mostly what I'd expect.
The visual results on screen may be a bit janky and could probably be improved but I'd expect that would make the code more complicated in this library.
Related to #1, fixes #22