-
Notifications
You must be signed in to change notification settings - Fork 149
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
remove rand as a public dependency + rollup and other cleanups #265
Merged
Commits on Dec 27, 2020
-
api: remove Send bound from Arbitrary/Testable traits
The Send bound is a relic from the past. Indeed, the docs for the Arbitrary trait have been outdated for quite some time. quickcheck stopped running each test in a separate thread once `std::panic::catch_unwind` was stabilized many moons ago. With `catch_unwind`, the `Send` bound is no longer necessary. We do need to retain the `'static` bound though. Without that, implementing shrink seems implausible. Fixes #262, Closes #263
Configuration menu - View commit details
-
Copy full SHA for c309676 - Browse repository at this point
Copy the full SHA c309676View commit details -
Configuration menu - View commit details
-
Copy full SHA for a699f79 - Browse repository at this point
Copy the full SHA a699f79View commit details -
api: make arbitrary use full number range
This commit tweaks the Arbitrary impls of number types (integers, floats) to use the full range with a small bias toward "problem" values. This is a change from prior behavior that would use the `size` parameter to control the range of integers. In retrospect, using the `size` parameter this way was probably misguided. Instead, it should only be used to control the sizes of data structures instead of also constraining numeric ranges. By constraining numeric ranges, we leave out a huge space of values that are never tested. Fixes #27, Fixes #119, Fixes #190, Fixes #233, Closes #240
Configuration menu - View commit details
-
Copy full SHA for 481c0c1 - Browse repository at this point
Copy the full SHA 481c0c1View commit details -
Configuration menu - View commit details
-
Copy full SHA for b2a6ba6 - Browse repository at this point
Copy the full SHA b2a6ba6View commit details -
rand: remove rand as a public dependency
This removes the use of the rand_core crate as a public dependency. It is now an implementation detail. We achieve this primarily by turning the `Gen` trait into a concrete type and fixing the fallout. This does make it impossible for callers to use their own `Gen` implementations, but it's unclear how often this was being used (if at all). This does also limit the number of RNG utility routines that callers have easy access to. However, it should be possible to use rand's `SeedableRng::from_{rng,seed}` routines to get access to more general RNGs. Closes #241
Configuration menu - View commit details
-
Copy full SHA for 57ba0d1 - Browse repository at this point
Copy the full SHA 57ba0d1View commit details -
This upgrades to the latest version of rand. Closes #264
Configuration menu - View commit details
-
Copy full SHA for db98d8d - Browse repository at this point
Copy the full SHA db98d8dView commit details -
Configuration menu - View commit details
-
Copy full SHA for 3153426 - Browse repository at this point
Copy the full SHA 3153426View commit details -
msrv: bump to 1.46.0 and specify policy
The next release will be a breaking change release anyway. We update a few other things as well. The examples in particular.
Configuration menu - View commit details
-
Copy full SHA for 668c333 - Browse repository at this point
Copy the full SHA 668c333View commit details
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.