Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Only build debug representations of arguments on failing tests #304

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

davidrusu
Copy link

@davidrusu davidrusu commented Dec 30, 2021

fixes #303

This cuts my prop test run-times nearly in half!

Here's the new flamegraph showing nearly 70% of time spent in test, previously this was 40%.

image
compare to prior run:
image

@davidrusu davidrusu changed the title Only build debug representations of arguments even on failing tests Only build debug representations of arguments on failing tests Dec 30, 2021
@davidrusu
Copy link
Author

@BurntSushi this change nets us a 50% reduction in quickcheck's overhead

It's a fairly small change, so hopefully quick to review. I'd love to see it merged in soon.

@neithernut
Copy link

neithernut commented Jan 12, 2022

There are bug-fixes pending for months. I wouldn't get my hopes up.

@dan-da
Copy link

dan-da commented Jan 15, 2022

+1 for getting this merged asap. else I'll need to start referencing @davidrusu's fork in our crates instead.

@niyaznigmatullin
Copy link

+1 is there anyone who wants to maintain this crate, probably we ask @BurntSushi to give rights or just use some other fork, @davidrusu's for instance, to continue developing this. The same is with crates.io, we could just create another crate

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

debug_reprs taking up 41% of test runtime
4 participants