Skip to content

Commit

Permalink
deps: remove vec-map feature from clap
Browse files Browse the repository at this point in the history
This removes the vec-map feature from clap. clap's README claims that
vec-map provides a small performance benefit, but I could observe any in
ripgrep workloads.

The benefit here is that it drops a dependency.

Amazingly, this drops whole release build times for ripgrep from 68s to
33s, and debug build time also decreases from 22s to 15.5s. This was
entirely unintentional but a welcome surprise.
  • Loading branch information
BurntSushi committed Feb 4, 2018
1 parent 68dac7c commit c8e755f
Show file tree
Hide file tree
Showing 2 changed files with 13 additions and 12 deletions.
13 changes: 3 additions & 10 deletions Cargo.lock

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

12 changes: 10 additions & 2 deletions Cargo.toml
Original file line number Diff line number Diff line change
Expand Up @@ -35,7 +35,6 @@ members = [ "grep", "globset", "ignore", "termcolor", "wincolor" ]
[dependencies]
atty = "0.2.2"
bytecount = "0.3.1"
clap = "2.26"
encoding_rs = "0.7"
grep = { version = "0.1.7", path = "grep" }
ignore = { version = "0.3.1", path = "ignore" }
Expand All @@ -50,14 +49,23 @@ same-file = "1"
termcolor = { version = "0.3.3", path = "termcolor" }
globset = { version = "0.2.1", path = "globset" }

[dependencies.clap]
version = "2.26"
default-features = false
features = ["suggestions", "color"]

[target.'cfg(windows)'.dependencies.winapi]
version = "0.3"
features = ["std", "winnt"]

[build-dependencies]
clap = "2.26"
lazy_static = "1"

[build-dependencies.clap]
version = "2.26"
default-features = false
features = ["suggestions", "color"]

[features]
avx-accel = ["bytecount/avx-accel"]
simd-accel = [
Expand Down

0 comments on commit c8e755f

Please sign in to comment.