Update --hidden help section to define hidden #1849
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BurntSushi
reviewed
Apr 15, 2021
crates/core/app.rs
Outdated
| @@ -1971,6 +1975,9 @@ fn flag_no_ignore_dot(args: &mut Vec<RGArg>) { | |||
| "\ | |||
| Don't respect .ignore files. | |||
|
|
|||
| This does **not** affect whether ripgrep will ignore files and directories | |||
There was a problem hiding this comment.
Just looking at other text, I think you just want *not* here instead of **not**. (This unfortunately isn't Markdown. It's AsciiDoc that gets converted into roff.)
dbjorge
commented
Apr 15, 2021
crates/core/app.rs
Outdated
| @@ -1971,6 +1975,9 @@ fn flag_no_ignore_dot(args: &mut Vec<RGArg>) { | |||
| "\ | |||
| Don't respect .ignore files. | |||
|
|
|||
| This does **not** affect whether ripgrep will ignore files and directories | |||
There was a problem hiding this comment.
This is technically inaccurate in that a .ignore file with negation patterns could affect whether ripgrep ignores dotfiles, but it felt overly verbose to clarify that as part of the note. If you have a better wording proposal that is more accurate, I'd be happy to update accordingly
BurntSushi
approved these changes
Apr 15, 2021
|
Thanks very much for the quick review! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1847
If you'd prefer to leave out the
--no-ignore-dotpart, I'm happy to update the PR accordinglyThanks!