adding HELSIOSPRING target fixes #57
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
orneryd
changed the title
kidBrazil
approved these changes
Mar 18, 2018
apocolipse
pushed a commit
that referenced
this pull request
Mar 22, 2018
* Second PT1 on DTerm This PR replaces the default biquad filter with a second PT1 set to 200Hz. Basically allows the user to enable a second, set point configurable, PT1 type first order low-pass filter on DTerm. This is useful because most noise in most logs arises from D, not P. The default is set to on, at twice the normal Dterm setpoint. This provides greater Dterm cut than a single PT1, and twice the steepness of cut above the second setpoint. Modelling shows significant reductions in higher frequency Dterm noise with only minor additional delay. The improvement in noise performance will be less than for biquad, but the delay is considerably less. If with the default settings the overall noise improves a lot, it may be possible bring D both filtering set points to higher numbers (e.g. 140/280), or alternatively remove other filters such as the notch filters, while maintaining an adequate level of control over noise. * Update names, old defaults, fix whitespace Defaults restored to biquad with second PT1 off. ‘lpf’ retained as abbreviation for values, otherwise generally remove ‘Filter’ where redundant, replace ‘FilterLpf’ with ‘Lowpass’, etc, thanks Fujin and DieHertz * Remove underscore in lowpass_2, add hz to setpoint for lowpass Thanks DieHertz * completed replacing lpf with lowpass, added _hz to all lowpass set points in profile Thanks DieHertz * fix whitespace fixed whitespace in settings.c * whitespace attempt #57 * change lpf to lowpass where appropriate elsewhere Note did not change OSD abbreviations, they are still LPF, and did not change gyro_lpf anywhere. * second attempt at a simple PT1 implementation Basically copied from the DtermNotch implementation * Second PT1 on DTerm This PR replaces the default biquad filter with a second PT1 set to 200Hz. Basically allows the user to enable a second, set point configurable, PT1 type first order low-pass filter on DTerm. This is useful because most noise in most logs arises from D, not P. The default is set to on, at twice the normal Dterm setpoint. This provides greater Dterm cut than a single PT1, and twice the steepness of cut above the second setpoint. Modelling shows significant reductions in higher frequency Dterm noise with only minor additional delay. The improvement in noise performance will be less than for biquad, but the delay is considerably less. If with the default settings the overall noise improves a lot, it may be possible bring D both filtering set points to higher numbers (e.g. 140/280), or alternatively remove other filters such as the notch filters, while maintaining an adequate level of control over noise. * Rebase * Remove underscore in lowpass_2, add hz to setpoint for lowpass Thanks DieHertz * completed replacing lpf with lowpass, added _hz to all lowpass set points in profile Thanks DieHertz * fix whitespace fixed whitespace in settings.c * whitespace attempt #57 * change lpf to lowpass where appropriate elsewhere Note did not change OSD abbreviations, they are still LPF, and did not change gyro_lpf anywhere. * second attempt at a simple PT1 implementation Basically copied from the DtermNotch implementation * Whitespace fix - thanks, Ledvinap * Fix PG issue by moving added dterm_lowpass2_hz to bottom of struct * Got rid of redundant indirection * Fixed indentantion shifts
orneryd
pushed a commit
that referenced
this pull request
May 21, 2018
* adding beeper inversion * adding RSSI ADC pin setting for target
orneryd
pushed a commit
that referenced
this pull request
May 28, 2018
remove filters in post for imuf add report errors cli command for imuf fixing defaults no overclock lowering Q on pitch only Bump patch fixing cpu overclock bricking issue. (#28) * removing code that affects other targets which was added in the helio target branch by accident * isolating more changes for helio * more define isolation of changes * changing startup registers for imuf and msd app to not conflict with the overclock request Using the Slack invite link (#30) Apply fixed K Kalman (#24) Corrected D-term filtering (#31) * correct_kd initial pancakes make everything more pacake like. cleanup names adding helio defaults * travis error fix imuf calibration initial (#32) update moron threshold. updating defaults for most people running true-x frames (#33) * updating defaults for most people running true-x frames and lowering Q since most people are having better flight mechanics lowering Q. * adding profiles for various types of quads default filter biquad for helio target (#35) Mach2 support for vtx_akk_hack (#36) * Mach2 support for vtx_akk_hack Different cmd queue for standard Smart Audio and akk / Mach 2 implementation. The used queue is depending on the vtx_akk_hack CLI setting. * Update version.h bump patch for release pinout was backwards RDQ Mach2 fixed queue full detection and port options Smart Audio queue full detection now also depends on the vtx_akk_hack cli option to return the truth about the queue being full. Port options reverted to the pre-broken initial value in case the vtx_akk_hack is enabled. Added target for Omnibus F4 Nano w/Black Box Added target for Airbot Omnibus F4 Nano v2.5 with support for blackbox (OBF4NANOBB) Added target for Omnibus F4 Nano w/Black Box Added target for Airbot Omnibus F4 Nano v2.5 with black box support. Target OBF4NANOBB Adding MK file for new Omnibus F4 Nano Target Implement vtx_akk_hack cli command as a switchable feature - Refactored the current CLI based implementation of vtx_akk_hack into a new feature named: "LEGACY_SA_SUPPORT" - Re-added the tailing byte in send frame as a possible fix for the "standard" implementation of Smart Audio, due to user reporting that turning the hack off for Unify and other "standard" SA VTX-es will result in an incorrect setting save issue (settings are only saved after unplugging and re-plugging the battery) - This PR should be accepted with the relevant Butterflight-Configurator PR that adds the "LEGACY_SA_SUPPORT" feature to the configuration tab - Incrementing the MSP protocol minor version to 39 and the EEPROM version is required before release Increment MSP protocol, EEPROM versions for new relese - Adding "LEGACY_SA_SUPPORT" as a feature to MSP requires this increment adding HELSIOSPRING target fixes (#57) * adding beeper inversion * adding RSSI ADC pin setting for target Changed default of gyro overflow back YAW. (#62) Fixed indentation in feature.h Fixed indentation in feature.h
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.