This repository has been archived by the owner on Jan 9, 2023. It is now read-only.
Add support for amqp+ssl URL's and configured username and password #17
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
matyaskuti
reviewed
Jul 31, 2018
There was a problem hiding this comment.
@maruno Could you extend the README as well with the (new) configuration possibilities?
qpid_bow/config.py
Outdated
| """ | ||
| if urls: | ||
| return [url.strip() for url in urls.split(',')] | ||
| splited_url = urlsplit(url.strip()) |
VERSION
Outdated
| @@ -1 +1 @@ | |||
| 1.0.2 | |||
| 1.0.3 | |||
There was a problem hiding this comment.
I'm not sure if this is only a patch version bump, since we are adding functionality in a backwards compatible manner, I might lean towards 1.1.0
There was a problem hiding this comment.
It's pretty minor, but sure.
docs/source/conf.py
Outdated
| @@ -15,7 +15,7 @@ | |||
| author = 'Bynder B.V.' | |||
|
|
|||
| version = '1.0' # The short X.Y version. | |||
| release = '1.0.2' # The full version, including alpha/beta/rc tags. | |||
| release = '1.0.3' # The full version, including alpha/beta/rc tags. | |||
There was a problem hiding this comment.
Same here about the versioning
qpid_bow/config.py
Outdated
| 'username' in config and 'password' in config): | ||
| user_pass = f"{config['username']}:{config['password']}@" | ||
| new_netloc = user_pass + splited_url.netloc | ||
| splited_url = splited_url._replace(netloc=new_netloc) |
There was a problem hiding this comment.
It's a form of namedtuple, eventhough it's mangled with the _ this is officially documented as the way to create a new one with changes: https://docs.python.org/3/library/collections.html#collections.somenamedtuple._replace
|
Tests failed in Travis! |
Pull Request Test Coverage Report for Build 28
💛 - Coveralls |
matyaskuti
approved these changes
Jul 31, 2018
maruno
requested review from
condemil and
mircea-cosbuc
and removed request for
condemil
mircea-cosbuc
approved these changes
Aug 1, 2018
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.