Optimize UI responsiveness in scanning state #209
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The UI is very laggy while the scanning is in progress, and it makes the program almost unusable during the first few seconds of startup. The bottleneck is
jwalk
iterator, it may block the UI thread sometimes. In this PR, I alleviated the situation by some optimizations, and the UI is now super responsive at startup.Here is what it looks like:
Screen.Recording.2024-01-05.at.19.41.10.mov
Some implementation notes:
crossbeam::channel
to receive UI events andjwalk
entries. In contract tostd::sync::mpsc
, we can select from a set of channels without busy polling usingtry_recv
.input_channel
. The function provided bycrosstermion
returns astd::sync::mpsc::Receiver
value, which is not compatible withcrossbeam::select!
.