-
Notifications
You must be signed in to change notification settings - Fork 112
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactors app initialisation #214
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks a lot for making this happen - I think it's a great base for implementing refresh later.
1f1dc6f
to
97a0340
Compare
I really like that the application will be able to trigger the refresh itself by creating a new It also seems that |
I have thought the same thing, and was the first thing that I have tried to do when working on this change. However I have ran into ownership / borrow checker issues. I may give it another go. |
Ups... all my messy commit "wip" history ended up being merged into main - I don't mind if you squash when landing the PR, but I will also try to remember to squash all the commits before sending stuff for review. |
No worries about it - I was aware and chose to prefer the detailed step-by-step history over a single commit that hides the steps. Even though I appreciate more structure, it's by no means a requirement and … I have been doing the same for a long time. StackedGit changed that to the better, but it comes with a little overhead that to me at least is worth it. |
This PR refactors app initialisation so that:
Traversal
.RunningTraversal
.Traversal
gets updated by processing events from theRunningTraversal
inside the main event loop.This should enable in future to implement refresh logic by creating another
RunningTraversal
and updating parts of the tree (TBD how to exactly do that).Other than the above
AppState
andTerminalApp
have been moved to separate files.