fix overhead #225
Merged
fix overhead #225
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously each time the UI refreshes, every 250ms, it display entries but also check their metadata to assure they exist. This could lead to performance loss when the displayed folder has a lot of entries.
This will possibly lead to incomplete results, but I find being able to use ones muscle-memory more important than preventing dealing with incomplete results. What happens to me is usually to type `/` followed by `target/` which tends to select all current entries for deletion.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to #223
Previously each time the UI refreshes, every 250ms, it display
entries but also check their metadata to assure they exist.
This could lead to performance loss when the displayed folder
has a lot of entries.