Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(windows): use std Command #63

Merged
merged 3 commits into from
Feb 5, 2023
Merged

feat(windows): use std Command #63

merged 3 commits into from
Feb 5, 2023

Commits on Feb 5, 2023

  1. feat(windows): use std Command 

    Use std `Command` instead of `ShellExecuteW` from windows sys crate.

This change was already attempted in: Byron#25
and later reverted in: Byron#27
and it it seems that it didn't work due to incorrect usage of
`explorer` instead of `cmd /c start`.
(see helix-editor/helix#5820 (comment)
for detailed explanation).

Related: helix-editor/helix#5820
    @matoous
    matoous committed Feb 5, 2023
    Configuration menu
    Copy the full SHA
    056cb00 View commit details
    Browse the repository at this point in the history

  2. refactor 

    - fix build
- don't quote path anymore as it's seemingly not required.
  After all, we are passing the argument directly.
    @Byron
    Byron committed Feb 5, 2023
    Configuration menu
    Copy the full SHA
    7ab725a View commit details
    Browse the repository at this point in the history

  3. remove win32-msvc from build matrix as it fails due to permission-den… 

    …ied with rustup.exe

This seems like an odd problem to have and nothign to spend time on given
the lack of importance of the win32 platform. We would except open-rs
to build fine on win32 if it builds for win64.
    @Byron
    Byron committed Feb 5, 2023
    Configuration menu
    Copy the full SHA
    1f4a9f9 View commit details
    Browse the repository at this point in the history