Add method to export trash path (issue #38) #67
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Byron
requested changes
May 3, 2023
| let path = PathBuf::from(get_unique_name()); | ||
| File::create(&path).unwrap(); | ||
|
|
||
| delete(&path).unwrap(); |
There was a problem hiding this comment.
Maybe adjust delete so that it returns the path to the deleted file to make it possible to assert that it lives within the trash_path().
|
Closing due to inactivity. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Up to now, there is no way of knowing where the files are going when removed. Of course you could use this specification, but doing that would require to duplicate the code for getting the trash directory on every user.
Possible solution
To fix this, public method
thrash_path()has been added to the public API along with tests and documentation. This methods returns the same Trash directory that the crate uses for removing files.Fixes issue #38.