Choose the longest valid mount point

[DarkKronicle]

If the user has a drive mounted at /run and /run/media/test, and they are trashing a file /run/media/test/remove-me, depending on the order the mount point iterates through, it could incorrectly choose /run as the mount point, leading to a failed trash.

This simple pull request takes the longest valid mount point and uses that for the trash directory. This should prevent the issue above.

Note: I have not done too much rust development, so I'm not entirely sure that this is the simplest way to solve this. Please let me know if you see of anything that can be improved.

Related: #57

[Byron]

Thanks a lot!

I gave it a go to make the code a little more idiomatic as well if you want to take a look.

However, I am a bit anxious about the performance impliciations of this change and would prefer if the mount-points that are passed in would be sorted to begin with.

Then the function could be simpler and continue using the first match, while also being less wasteful.

Is this something you would want to do for practice?

[DarkKronicle]

Thanks for the quick response!

I can give it a shot, but wouldn't this just increase the time complexity? Right now this runs in O(n) time, and a sort would bring that up to O(n log n).

[Byron]

Thanks!

The idea was to pre-sort the mount-points, as this functions seems to be called in a couple of places and potentially many items. If it makes no sense to you, I'd understand, it can certainly be merged as is without anybody filing complaints about performance.

[DarkKronicle]

Oh, I see what you're saying. I think that's smarter.

[DarkKronicle]

Ok, how does this look?

[Byron]

Thanks a lot, this should work.

I will create a new patch release soon after merging.

[Byron]

And here it is: https://github.com/Byron/trash-rs/releases/tag/v3.2.1

[DarkKronicle]

Awesome, thank you!