Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add cmd get, delete, keys #119

Merged
merged 3 commits into from
Jul 1, 2023
Merged

add cmd get, delete, keys #119

merged 3 commits into from
Jul 1, 2023

Conversation

Moeen89
Copy link
Contributor

@Moeen89 Moeen89 commented Jun 26, 2023

#115 , I will be happy to help if there is a problem. also I handled using put command before start.

cmd/data.go Outdated
fmt.Println("get data error: ", err)
return err
}
fmt.Println(string(value[:]))
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

map be it can replace value[:] with value?

cmd/data.go Outdated
}
err := db.Delete([]byte(key))
if err != nil {
fmt.Println("get data error: ", err)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

delete data?

cmd/data.go Outdated
}
list := db.GetListKeys()
for i, bytes := range list {
fmt.Println(i+1, "- ", string(bytes[:]))
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The display information may be optimized and more detailed

@Moeen89
Copy link
Contributor Author

Moeen89 commented Jun 29, 2023

Is it okay now? If it's not, please let me know what is the problem.

@sjcsjc123
Copy link
Member

thanks

@sjcsjc123 sjcsjc123 merged commit ac62a47 into ByteStorage:master Jul 1, 2023
2 checks passed
saeid-a pushed a commit to saeid-a/FlyDB that referenced this pull request Jul 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants