Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Missing rowDelimiter at end of last line #54

Closed
berlincount opened this issue Aug 12, 2014 · 3 comments
Closed

Missing rowDelimiter at end of last line #54

berlincount opened this issue Aug 12, 2014 · 3 comments

Comments

@berlincount
Copy link

The last line doesn't get a finishing "\n", which messes up legacy code.

What's the best way to add that? (using a stream with transformation).

Didn't seem to be able to find the right place to a write or a push.
doug-martin added a commit to doug-martin/fast-csv that referenced this issue Aug 14, 2014
@doug-martin
v0.4.3
64fb355 
* Added ability to include a `rowDelimiter` at the end of a csv with the `includeEndRowDelimiter` optioin C2FO#54
* Added escaping for values that include a row delimiter
* Added more tests for new feature and escaping row delimiter values.
@doug-martin doug-martin mentioned this issue Aug 14, 2014
Merged
@doug-martin
Copy link
Contributor

There is now an option called includeEndRowDelimiter which will append a final row delimiter to the generated CSV

@berlincount
Copy link
Author

\o/

Cheers!

@berlincount
Copy link
Author

Works exactly as advertised, thanks a lot!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@doug-martin @berlincount