Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #1014 Tester responses: All bugs are marked as 'Faulty Issues' #1020

Merged
merged 4 commits into from
Oct 17, 2022

Conversation

luminousleek
Copy link
Contributor

Summary:

Fixes #1014

Changes Made:

  • Update tester response parser to take into account message warning against editing issue on GitHub directly. Note that the parser still works if the message is not in the issue comment
  • Update test to include this message

Proposed Commit Message:

Update Tester Response Parser to account for editing on GitHub warning

A message warning students against responding to the issue directly
on GitHub was added to the Tester Response comment, causing the parser
to mark all issues as faulty as this message was not originally in the
parser.

Let's add this message into the parser so that it can parse tester
response comments correctly, and let's update the tests to include
this message

@codecov-commenter
Copy link

Codecov Report

Base: 62.26% // Head: 62.37% // Increases project coverage by +0.10% 🎉

Coverage data is based on head (a00e8a6) compared to base (4ef3064).
Patch coverage: 100.00% of modified lines in pull request are covered.

Additional details and impacted files
@@             Coverage Diff             @@
##           release    #1020      +/-   ##
===========================================
+ Coverage    62.26%   62.37%   +0.10%     
===========================================
  Files           86       86              
  Lines         1937     1940       +3     
  Branches       215      215              
===========================================
+ Hits          1206     1210       +4     
+ Misses         695      694       -1     
  Partials        36       36              
Impacted Files Coverage Δ
...models/templates/tester-response-template.model.ts 91.17% <100.00%> (+0.85%) ⬆️
...rc/app/shared/issue/assignee/assignee.component.ts 86.20% <0.00%> (ø)
src/app/shared/issue-tables/issue-sorter.ts 47.82% <0.00%> (+4.34%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

Copy link
Contributor

@chunweii chunweii left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. This solves the critical issue but I am not too sure if that edit warning will also be in other phases. If the warning is included, we should parse the warning in all phases.

@damithc
Copy link
Contributor

damithc commented Oct 17, 2022

LGTM. This solves the critical issue but I am not too sure if that edit warning will also be in other phases. If the warning is included, we should parse the warning in all phases.

Good point, but for now, it is only in the tester response phase.

@damithc
Copy link
Contributor

damithc commented Oct 17, 2022

@kkangs0226 can do a hot-patch release for this too?

@chunweii chunweii merged commit d8c7240 into CATcher-org:release Oct 17, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants