Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Standardize logging formats and add more logging #1147

Merged

Conversation

cheehongw
Copy link
Contributor

Summary:

Standardize logging formats and add more logging

Changes Made:

  • Renamed all instances of loggingService to logger
  • Update the format of logging messages to follow codefile: action
  • Add logging messages for requests and responses, and for signing the user out.

Proposed Commit Message:

Standardize logging formats and add more logging.

Let's specify where log statements are being generated, and add more 
logging statements to aid in diagnostics.

@codecov-commenter
Copy link

codecov-commenter commented Feb 27, 2023

Codecov Report

Base: 53.58% // Head: 53.42% // Decreases project coverage by -0.16% ⚠️

Coverage data is based on head (2a840ac) compared to base (8e9595f).
Patch coverage: 36.36% of modified lines in pull request are covered.

📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1147      +/-   ##
==========================================
- Coverage   53.58%   53.42%   -0.16%     
==========================================
  Files         100      100              
  Lines        2721     2727       +6     
  Branches      512      512              
==========================================
- Hits         1458     1457       -1     
- Misses        926      931       +5     
- Partials      337      339       +2     
Impacted Files Coverage Δ
...h/session-selection/session-selection.component.ts 39.53% <0.00%> (ø)
src/app/core/services/auth.service.ts 13.15% <0.00%> (-0.55%) ⬇️
src/app/core/services/github.service.ts 16.19% <ø> (-0.12%) ⬇️
src/app/core/services/issue.service.ts 8.85% <0.00%> (ø)
.../shared/comment-editor/comment-editor.component.ts 18.66% <ø> (ø)
.../app/shared/issue-tables/issue-tables.component.ts 37.37% <25.00%> (ø)
src/app/core/services/error-handling.service.ts 64.28% <100.00%> (ø)
src/app/core/services/user.service.ts 75.60% <100.00%> (-1.32%) ⬇️
src/app/shared/issue-tables/issue-sorter.ts 36.36% <0.00%> (-9.10%) ⬇️
... and 2 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@vigneshsankariyer1234567890 vigneshsankariyer1234567890 merged commit 2fbbd04 into CATcher-org:master Feb 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants