-
Notifications
You must be signed in to change notification settings - Fork 68
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixes rendering for checkboxes #1155
Fixes rendering for checkboxes #1155
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
☑️ LGTM ☑️
Would be good to see how the emoji looks like on different OSes
Are we using an icon font such as fontawesome? In that case we can try using matching icons provided by the font, as they will look the same in all browsers. |
Codecov ReportPatch coverage:
📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more Additional details and impacted files@@ Coverage Diff @@
## master #1155 +/- ##
==========================================
- Coverage 53.82% 53.81% -0.01%
==========================================
Files 99 99
Lines 2696 2698 +2
Branches 497 498 +1
==========================================
+ Hits 1451 1452 +1
- Misses 915 916 +1
Partials 330 330
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
…e-previewed-as-bullet-points
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Checked that the issue has been fixed, LGTM.
Let's include the addition of font-awesome icons in the commit message as well.
Also, please follow this guide for crafting your commit messages. https://se-education.org/guides/conventions/git.html
…e-previewed-as-bullet-points
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
…e-previewed-as-bullet-points
Summary:
Fixes #1152
Changes Made:
Proposed Commit Message: