Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove certain buttons in markdown toolbar #1196

Merged
merged 1 commit into from
Jul 11, 2023

Conversation

chia-yh
Copy link
Contributor

@chia-yh chia-yh commented Jun 18, 2023

Summary:

Fixes #1178

Changes Made:

  • markdown-toolbar.component.html: remove md-mention and md-ref buttons as they do not provide significant benefits in the context of a PE
  • comment-editor.component.spec.ts: remove md-mention and md-ref from button tests

Proposed Commit Message:

Remove certain buttons in markdown toolbar

"Mention a user" and "Reference an issue, pull request or discussion" 
buttons in the markdown toolbar do not provide significant benefits in 
the context of a PE due to the lack of functionality and intended 
anonymity in the PE environment.

Removing these buttons avoids any potential confusion among users 
arising from the lack of support for these buttons.

Let's avoid any confusion by removing these buttons from the markdown 
toolbar.

"Mention a user" and "Reference an issue, pull request or discussion"
buttons in the markdown toolbar do not provide significant benefits in
the context of a PE due to the lack of functionality and intended
anonymity in the PE environment.

Removing these buttons avoids any potential confusion among users
arising from the lack of support for these buttons.

Let's avoid any confusion by removing these buttons from the markdown
toolbar.
Copy link
Contributor

@Eclipse-Dominator Eclipse-Dominator left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can confirm that the buttons responsible for mentions and references have been removed.

Great work!

@codecov-commenter
Copy link

Codecov Report

Patch and project coverage have no change.

Comparison is base (94134a8) 54.63% compared to head (0e1c5ec) 54.63%.

❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #1196   +/-   ##
=======================================
  Coverage   54.63%   54.63%           
=======================================
  Files         101      101           
  Lines        2888     2888           
  Branches      535      535           
=======================================
  Hits         1578     1578           
  Misses        967      967           
  Partials      343      343           

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

Copy link
Contributor

@gycgabriel gycgabriel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@gycgabriel gycgabriel merged commit 224172b into CATcher-org:master Jul 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Removal of certain buttons in the markdown toolbar
5 participants