Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix timeline-header css #1206

Merged
merged 2 commits into from
Sep 18, 2023
Merged

Fix timeline-header css #1206

merged 2 commits into from
Sep 18, 2023

Conversation

LJXSean
Copy link
Contributor

@LJXSean LJXSean commented Aug 26, 2023 •
edited
Loading

Summary:

Fixes #1195

Changes Made:

  • Add styles to timeline-header class in styles.css and parse-error.component.css
  • Removed inline styling from the span of the following components:
    • issue-dispute.component
    • new-team-response.component
    • tester-response.component

image

Proposed Commit Message:

Vertically center titles of timeline-header class

Eclipse-Dominator
Eclipse-Dominator approved these changes Sep 18, 2023
View reviewed changes
Copy link
Contributor

@Eclipse-Dominator Eclipse-Dominator left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@chunweii chunweii merged commit 564b8ca into CATcher-org:master Sep 18, 2023
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Eclipse-Dominator Eclipse-Dominator Eclipse-Dominator approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Title not vertically centered in components using the class timeline-header
3 participants
@LJXSean @Eclipse-Dominator @chunweii