Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix e2e regression caused by changes in AuthService #1275

Merged

Conversation

cheehongw
Copy link
Contributor

Summary:

Fixes #1274

Changes Made:

Added missing method signatures in MockAuthService so that it exists and can be called when the application is running in a test environment such as Playwright. They are:

  • navigateToLandingPage
  • clearNext
  • storeNext
  • getNext

It is also the reason why our Playwright tests are failing - the test environment crashes when it runs into the new method signatures that are not defined in MockAuthService.

Proposed Commit Message:

Fix e2e regression caused by changes in AuthService

Previously, a PR introduced new method signatures in AuthService.
However, these were not introduced in MockAuthService, causing 
the testing environment to fail when the application encountered these
undefined method signatures.

Lets address this regression by adding the method signatures for these
methods.

@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 58.84%. Comparing base (5e7ed48) to head (955b20a).
Report is 8 commits behind head on master.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1275      +/-   ##
==========================================
+ Coverage   54.82%   58.84%   +4.01%     
==========================================
  Files         105      105              
  Lines        2858     2573     -285     
  Branches      503      289     -214     
==========================================
- Hits         1567     1514      -53     
+ Misses       1030     1009      -21     
+ Partials      261       50     -211     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@luminousleek luminousleek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for the quick fix! Now the Playwright tests are working

@luminousleek luminousleek merged commit f204db3 into CATcher-org:master Apr 27, 2024
4 of 5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Regression in playwright tests after changes to login flow
3 participants