-
Notifications
You must be signed in to change notification settings - Fork 68
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
New release for v3.5.4 #1280
New release for v3.5.4 #1280
Commits on Jan 25, 2024
-
Fix broken duplicate link (#1233)
Fix the broken link of a duplicate issue Currently, the user cannot open the link to a duplicate issue when opening an issue, as described in #1228. The links now work as expected.
Configuration menu - View commit details
-
Copy full SHA for b20b3ef - Browse repository at this point
Copy the full SHA b20b3efView commit details -
Add whitespace validation (#1237)
* Add whitespace validation * Update whitespace validation for new issue * Update whitespace validation for title of new issues * Update whitespace validation for title of new issues * Move validators into core * Update import order --------- Co-authored-by: Misra Aditya <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for fe7be44 - Browse repository at this point
Copy the full SHA fe7be44View commit details
Commits on Feb 2, 2024
-
Fix uncaught errors when attempting to access an invalid route
There is an uncaught error when the users click on an invalid internal link in Markdown or enter an invalid link in browser. Internal links are unlikely to be used for bug reporting and are more likely to be invalid. Let's show an error toaster and stop the navigation when clicking on an internal link in Markdown. Also, redirect the users to the login page if the users enter invalid link in browser.
Configuration menu - View commit details
-
Copy full SHA for d4b5422 - Browse repository at this point
Copy the full SHA d4b5422View commit details
Commits on Feb 8, 2024
-
Previously, image uploads depend on the user's default branch. Now, we set the branch for image upload to be `main`. Images will be uploaded to `main` as a result. --------- Co-authored-by: Chee Hong <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for 2c18b71 - Browse repository at this point
Copy the full SHA 2c18b71View commit details
Commits on Feb 12, 2024
-
With preserving linebreaks, subset list items are rendered as a list, and paragraph rendering is the same as Github.
Configuration menu - View commit details
-
Copy full SHA for a9d38dd - Browse repository at this point
Copy the full SHA a9d38ddView commit details
Commits on Feb 19, 2024
-
Faulty list view when back navigating (#1243)
Issue table settings such as page index are not saved when table is re-mounted. This behavior inconveniences users as their settings are reset everytime they navigate to a specific issue and back. Let's lift up the table settings of each mounted table to a service which the tables pull from when mounted.
Configuration menu - View commit details
-
Copy full SHA for a1b5000 - Browse repository at this point
Copy the full SHA a1b5000View commit details -
Some of our packages are old and outdated. We should actively maintain and keep these packages up-to-date so it is easier to maintain in the future. Let's upgrade to Angular 12 to keep our packages up-to-date.
Configuration menu - View commit details
-
Copy full SHA for e319865 - Browse repository at this point
Copy the full SHA e319865View commit details
Commits on Feb 21, 2024
-
Fix markdown blockquote preview difference (#1245)
Due to DOMPurify, the content used for preview is different. However, given that ngx-markdown already has sufficient sanitation by default, we remove sanitation by DOMPurify.
Configuration menu - View commit details
-
Copy full SHA for 944a424 - Browse repository at this point
Copy the full SHA 944a424View commit details
Commits on Mar 4, 2024
-
Configuration menu - View commit details
-
Copy full SHA for 5e7ed48 - Browse repository at this point
Copy the full SHA 5e7ed48View commit details
Commits on Mar 28, 2024
-
Resolve issue of allocating invalid assignees
Currently, when a user attempts to submit a team response with an invalid assignee (defined as an assignee who has not joined the organization), the team response is processed (by adding the team response GitHub comment) before the assignee checks are made. The error message for an invalid assignee is also vague, only stating "Validation Failed", with no additional context. This causes the issue to be erroneously classified as “Responded” when it has not actually been properly responded to as the “assignee” field would be left empty. The vague invalid assignee message also means users will not know what to do to fix the issue. This issue can be resolved by inverting the logic of team responses, ensuring the assignee validity is checked before making the team response comment. If the assignee is invalid, then the team response comment is never created, thus avoiding the erroneous classification. Also provided custom error parsing for invalid assignees to display proper reasons and actions for the validation failure for users to rectify the issue. A proper diagram of the inversion of logic can be found in the pull request: #1264 (comment)
Configuration menu - View commit details
-
Copy full SHA for 62ef100 - Browse repository at this point
Copy the full SHA 62ef100View commit details
Commits on Apr 12, 2024
-
wait-on doesn't seem to be used at all in our workflows. Let's remove it.
Configuration menu - View commit details
-
Copy full SHA for 21ca2cd - Browse repository at this point
Copy the full SHA 21ca2cdView commit details -
Add importHelpers option to tsconfig
In order to use tslib, we need to include this compiler option in tsconfig. Based off clean installs of angular 12 projects via ng new, this setting appears to be the default as well. See: - https://angular.io/guide/typescript-configuration#tsconfig - From https://www.npmjs.com/package/tslib
Configuration menu - View commit details
-
Copy full SHA for 70fec00 - Browse repository at this point
Copy the full SHA 70fec00View commit details -
Remove node-fetch as direct dependency
CATcher does not directly depend on node-fetch. After the removal of electron, there are no more files depending on node-fetch.
Configuration menu - View commit details
-
Copy full SHA for c2713f6 - Browse repository at this point
Copy the full SHA c2713f6View commit details -
- Remove `wait-on` as devDep - Added `importHelpers: true` in `tsconfig.json` as part of `tslib` - Remove `node-fetch` as dependency
Configuration menu - View commit details
-
Copy full SHA for 05fe528 - Browse repository at this point
Copy the full SHA 05fe528View commit details
Commits on Apr 15, 2024
-
Previously, upon login, users are brought to the default landing page of the phase. We redirect to the intended landing page, with appropriate next route checking.
Configuration menu - View commit details
-
Copy full SHA for 9690676 - Browse repository at this point
Copy the full SHA 9690676View commit details
Commits on Apr 26, 2024
-
Add documentation for CATcher's parser (#1240)
When CATcher's parsers were updated to use arcsecond, there was minimal documentation within the codebase to explain how the parsers work. As such, it was difficult to understand and maintain these parsers. Let's add examples for each comment template and explain the parsers that are more difficult to understand.
Configuration menu - View commit details
-
Copy full SHA for c7461b2 - Browse repository at this point
Copy the full SHA c7461b2View commit details -
Migrate from TSLint to ESLint (#1250)
TSLint is now deprecated in favour of ESLint. We should keep our dependencies up-to-date. Let's migrate to ESLint to ensure that our linter is up-to-date. --------- Co-authored-by: Misra Aditya <[email protected]> Co-authored-by: Wong Chee Hong <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for 5a91541 - Browse repository at this point
Copy the full SHA 5a91541View commit details
Commits on Apr 27, 2024
-
Fix e2e regression caused by changes in AuthService
Previously, a PR introduced new method signatures in AuthService. However, these were not introduced in MockAuthService, causing the testing environment to fail when the application encountered these undefined method signatures. Lets address this regression by adding the method signatures for these methods.
Configuration menu - View commit details
-
Copy full SHA for f204db3 - Browse repository at this point
Copy the full SHA f204db3View commit details -
Some of our packages are old and outdated. We should actively maintain and keep these packages up-to-date so it is easier to maintain in the future. Let's upgrade to Angular 13 to keep our packages up-to-date.
Configuration menu - View commit details
-
Copy full SHA for ed71498 - Browse repository at this point
Copy the full SHA ed71498View commit details
Commits on Sep 30, 2024
-
Configuration menu - View commit details
-
Copy full SHA for 6830c82 - Browse repository at this point
Copy the full SHA 6830c82View commit details