Graphql migration #453
Merged
Graphql migration #453
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Integrate Apollo
This reverts commit 233b343.
Master -> graphql-migration
In this PR: - Migrated fetch issue/issues api to use graphql. - Load time of 110 issues is around 3 seconds. - All the polling is done in background, so user will not face any load time during page navigation. - Updated [developer notes](https://github.com/CATcher-org/CATcher/blob/6263a01fcb97356eb937d28e96a424011e5b2de0/docs/developer-notes.md) on setting up the project with graphql
…Wei96/CATcher into graphql-migration-issues-api
…sues-api Graphql migration issues api
ptvrajsk
approved these changes
Aug 27, 2020
|
I've done a round of testing on the 4 phases, and no issues were identified |
anubh-v
reviewed
Sep 11, 2020
anubh-v
approved these changes
Sep 12, 2020
anubh-v
reviewed
Sep 12, 2020
anubh-v
reviewed
Sep 12, 2020
src/app/core/models/github/cache-manager/comments-cache-manager.model.ts
Outdated
Show resolved
Hide resolved
anubh-v
reviewed
Sep 12, 2020
anubh-v
approved these changes
Sep 12, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In this PR:
Limitation:
TODO after merged:
octokit/graphql-schema.Resolves #428
Resolves #427
Resolves #410