Refactor session validation logic in Phase Service / AuthComponent #472
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JunWei96
reviewed
Sep 26, 2020
…refactor-auth-setup-session
anubh-v
changed the title
anubh-v
changed the title
JunWei96
reviewed
Oct 5, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In this PR, I have added a new operator that asserts whether a
SessionDataobject meets all our required constraints(e.g. is there at least one open phase ?).
This operator can be used directly in the Observable pipelines.
Benefits of this new operator:
mapoperators along with other logic. Now, we can perform the validation as an independent step in the Observables' pipeline. Separating themapand validation logic should make the overall pipeline more readable.