-
Notifications
You must be signed in to change notification settings - Fork 68
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add tests for session selection component #973
Add tests for session selection component #973
Conversation
tests/app/auth/session-selection/session-selection.component.spec.ts
Outdated
Show resolved
Hide resolved
tests/app/auth/session-selection/session-selection.component.spec.ts
Outdated
Show resolved
Hide resolved
@chunweii Thanks for your review :) I've made the changes and pushed accordingly. |
Codecov ReportBase: 62.31% // Head: 60.31% // Decreases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## master #973 +/- ##
==========================================
- Coverage 62.31% 60.31% -2.01%
==========================================
Files 86 95 +9
Lines 1937 2046 +109
Branches 215 220 +5
==========================================
+ Hits 1207 1234 +27
- Misses 695 777 +82
Partials 35 35
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
Summary:
Fixes #972
Changes Made:
ProfilesComponent
emits a profile, the selected profile'srepoName
is correctly reflected in the session input.Proposed Commit Message: