Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add tests for session selection component #973

Merged

Conversation

snss231
Copy link
Contributor

@snss231 snss231 commented Jul 20, 2022

Summary:

Fixes #972

Changes Made:

  • Add unit test to ensure that when the child ProfilesComponent emits a profile, the selected profile's repoName is correctly reflected in the session input.

Proposed Commit Message:

SessionSelectionComponent: add tests

Let's add a test to verify that the SessionSelectionComponent
shows the correct repo name in the session input when the
selected profile is emitted from the child ProfilesComponent.

@snss231
Copy link
Contributor Author

snss231 commented Sep 22, 2022

@chunweii Thanks for your review :) I've made the changes and pushed accordingly.

@codecov-commenter
Copy link

codecov-commenter commented Sep 22, 2022

Codecov Report

Base: 62.31% // Head: 60.31% // Decreases project coverage by -2.00% ⚠️

Coverage data is based on head (47b3a73) compared to base (d85e0c6).
Patch has no changes to coverable lines.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #973      +/-   ##
==========================================
- Coverage   62.31%   60.31%   -2.01%     
==========================================
  Files          86       95       +9     
  Lines        1937     2046     +109     
  Branches      215      220       +5     
==========================================
+ Hits         1207     1234      +27     
- Misses        695      777      +82     
  Partials       35       35              
Impacted Files Coverage Δ
...p/shared/action-toasters/action-toasters.module.ts 100.00% <0.00%> (ø)
.../app/shared/error-toasters/error-toaster.module.ts 100.00% <0.00%> (ø)
...shared/error-toasters/toaster/toaster.component.ts 50.00% <0.00%> (ø)
...h/session-selection/session-selection.component.ts 41.17% <0.00%> (ø)
...tials-error/invalid-credentials-error.component.ts 50.00% <0.00%> (ø)
.../core/directives/form-disable-control.directive.ts 50.00% <0.00%> (ø)
src/app/shared/lib/session.ts 0.00% <0.00%> (ø)
src/app/core/services/auth.service.ts 9.52% <0.00%> (ø)
src/app/shared/shared.module.ts 100.00% <0.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@gycgabriel gycgabriel merged commit ce3c1ab into CATcher-org:master Oct 7, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

SessionSelectionComponent: Add Component Test
5 participants