Changes following PR review @edeno

CBroz1 · Feb 9, 2024 · 002df04 · 002df04
1 parent 37be01b
commit 002df04
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 2 deletions.
diff --git a/src/spyglass/common/common_usage.py b/src/spyglass/common/common_usage.py
@@ -31,6 +31,7 @@ class InsertError(dj.Manual):
     ---
     dj_user: varchar(64)
     connection_id: int     # MySQL CONNECTION_ID()
+    nwb_file_name: varchar(64)
     table: varchar(64)
     error_type: varchar(64)
     error_message: varchar(255)

diff --git a/src/spyglass/common/populate_all_common.py b/src/spyglass/common/populate_all_common.py
@@ -44,6 +44,7 @@ def populate_all_common(nwb_file_name):
     error_constants = dict(
         dj_user=dj.config["database.user"],
         connection_id=dj.conn().connection_id,
+        nwb_file_name=nwb_file_name,
     )
 
     for table in tables:
@@ -62,8 +63,10 @@ def populate_all_common(nwb_file_name):
             )
     query = InsertError & error_constants
     if query:
+        err_tables = query.fetch("table")
         logger.error(
-            f"Errors occurred during population:\n{query}\n"
-            + "See common_useage.InsertError for more details"
+            f"Errors occurred during population for {nwb_file_name}:\n\t"
+            + f"Failed tables {err_tables}\n\t"
+            + "See common_usage.InsertError for more details"
         )
         return query.fetch("KEY")