Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use docker container for rules that use R #129

Merged
merged 17 commits into from
May 29, 2024
Merged

Use docker container for rules that use R #129

merged 17 commits into from
May 29, 2024

Conversation

kelly-sovacool
Copy link
Member

@kelly-sovacool kelly-sovacool commented Apr 12, 2024

Changes

Use a container with R package dependencies already installed rather than install them to a shared library path. Deprecate the Rlib_dir and Rpkg_config options. Use one container for the three rules that require R.

This also fixes a bug in the driver script that prevented the singularity bind paths from being parsed correctly. With this PR, we can begin containerizing rules one by one.

Issues

PR Checklist

(Strikethrough any points that are not applicable.)

  • This comment contains a description of changes with justifications, with any relevant issues linked.
  • [ ] Update docs if there are any API changes.
  • Update CHANGELOG.md with a short description of any user-facing changes and reference the PR number. Guidelines: https://keepachangelog.com/en/1.1.0/

@kelly-sovacool kelly-sovacool self-assigned this Apr 15, 2024
@kelly-sovacool kelly-sovacool changed the title Use docker container for deseq rule Use docker container for rules that use R Apr 17, 2024
@kelly-sovacool
Copy link
Member Author

test run in progress

bash /data/CCBR_Pipeliner/Pipelines/CARLISLE/carlisle-dev-sovacool/carlisle \
  --runmode=runtest \
  --workdir=/data/sovacoolkl/carlisle_test_129

@kelly-sovacool kelly-sovacool marked this pull request as ready for review May 29, 2024 14:50
@kelly-sovacool kelly-sovacool merged commit 4e2b72c into main May 29, 2024
@kelly-sovacool kelly-sovacool deleted the deseq-docker branch May 29, 2024 14:51
@kelly-sovacool kelly-sovacool added this to the 2024-05 milestone Jul 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Switch to containers and remove code related to R library paths & R package installation
1 participant