Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add new rules visualizing CARLISLE results #132

Merged
merged 23 commits into from
Jun 12, 2024

Conversation

epehrsson
Copy link
Collaborator

@epehrsson epehrsson commented May 23, 2024

Changes

Adds rules:

  • count_peaks - output table with number of peaks per condition, visualize number of peaks and correlation between dedup and no_dedup peaks
  • cov_correlation - find Pearson correlation in genome-wide coverage for all samples, plot heatmap and PCA
  • homer_enrich - visualize HOMER enrichment over genic features for each condition
  • combine_homer - add MACS2 fold change and q-value to HOMER annotation table

PR Checklist

  • This comment contains a description of changes with justifications, with any relevant issues linked.
  • Update docs if there are any API changes. - none
  • Update CHANGELOG.md with a short description of any user-facing changes and reference the PR number. Guidelines: https://keepachangelog.com/en/1.1.0/

@kelly-sovacool
Copy link
Member

Thanks for opening this PR, @epehrsson! Sorry I didn't notice it -- in the future you can tag me with @kelly-sovacool somewhere in the this thread to notify me if you want me to review it.

Were you able to run this successfully on biowulf?

@epehrsson
Copy link
Collaborator Author

Hi @kelly-sovacool, sorry for not tagging you! Yes, I could run it on the test data and on two projects I'd processed earlier, which recapitulated the results of the rules. =

@kelly-sovacool
Copy link
Member

Thanks for this contribution @epehrsson! I proposed changes here so that your new rules will also use the docker container. Please take a look and merge that if it looks good, then we'll run one more test to make sure I didn't break anything before merging this PR into main.

@epehrsson
Copy link
Collaborator Author

epehrsson commented May 30, 2024

Thanks, @kelly-sovacool ! The changes look good, and I completed the pull request.

workflow/rules/annotations.smk Outdated Show resolved Hide resolved
epehrsson and others added 2 commits May 31, 2024 10:26
Update input files for homer_enrich to include non-MACS2 treatment-control lists

Co-authored-by: Kelly Sovacool <[email protected]>
epehrsson and others added 2 commits May 31, 2024 12:12
fix merge conflicts in CCBR/main
also refactor combine_homer Rscript to use tidyverse
kelly-sovacool and others added 3 commits June 7, 2024 09:26
Patrick had a transient error with library(tidyverse) where it failed to load stringr
fix: ignore "#" comment lines in peaks files
@kelly-sovacool kelly-sovacool self-requested a review June 12, 2024 12:38
@kelly-sovacool kelly-sovacool merged commit 235f74e into CCBR:main Jun 12, 2024
@epehrsson epehrsson deleted the correlation branch July 15, 2024 20:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants