-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add new rules visualizing CARLISLE results #132
Conversation
Thanks for opening this PR, @epehrsson! Sorry I didn't notice it -- in the future you can tag me with Were you able to run this successfully on biowulf? |
Hi @kelly-sovacool, sorry for not tagging you! Yes, I could run it on the test data and on two projects I'd processed earlier, which recapitulated the results of the rules. = |
Thanks for this contribution @epehrsson! I proposed changes here so that your new rules will also use the docker container. Please take a look and merge that if it looks good, then we'll run one more test to make sure I didn't break anything before merging this PR into main. |
Update docker for new viz rules
Thanks, @kelly-sovacool ! The changes look good, and I completed the pull request. |
Update input files for homer_enrich to include non-MACS2 treatment-control lists Co-authored-by: Kelly Sovacool <[email protected]>
fix merge conflicts in CCBR/main
also refactor combine_homer Rscript to use tidyverse
Patrick had a transient error with library(tidyverse) where it failed to load stringr
fix: ignore "#" comment lines in peaks files
Changes
Adds rules:
PR Checklist
CHANGELOG.md
with a short description of any user-facing changes and reference the PR number. Guidelines: https://keepachangelog.com/en/1.1.0/