-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Uploaded new test dataset for github workflow #107
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could we move all the test files from .tests/
to tests/data/
? This location would be more standard.
I found some instances of grep -rl "\.tests" *
I went ahead and fixed them with: grep -rl "\.tests" * | xargs sed -ri "s|\.tests|tests/data|g" |
I have a full run in progress with the new test dataset, will let you know how it goes |
The full run will fail because these are 0.5% of all sampled reads and will fail at the CNV calling step. I only uploaded these here for dryrun tests as they were small enough. In my tests, the 25% subsampled reads (~800 mb/file) run to completion without errors. Anything below that would fail to call CNVs due to low coverage. |
Oh, the purpose of uploading real data (rather than blank files) is so we can run real non-dry runs to test the actual functionality and not just the workflow logic. Is there a way we can have an option to relax restrictions for the CNV callers so they run to completion with this small subsample? Ideally we would not advertise such an option for users and it would only exist for testing. Also, can you copy your 25% subsampled data to a subdir here, so we can use it for manual testing on biowulf? |
CNV calls are added as |
Ok, so we can at least run it without CNV entirely to test the other parts of the pipeline. That's still worth doing, definitely better than only a dry run. |
Okay. Let me do a full run of XAVIER without CNV calling on the uploaded test dataset (0.5%) and see if it runs. Will post an update. |
Mine is in progress, so there's no need for you to run it too unless you just want to! |
But everything else completed successfully (340/343 steps). |
I moved them to a subdir called chmod a+r /data/CCBR_Pipeliner/testdata/XAVIER/human_subset/* |
p.s. I edited your first PR comment to say |
Thanks for your work on this @samarth8392 🎉 |
go team 😄 |
Changes
main.yaml
file in github workflow.Issues
Resolves #27
PR Checklist
(
Strikethroughany points that are not applicable.)- [ ] Update docs if there are any API changes.CHANGELOG.md
with a short description of any user-facing changes and reference the PR number. Guidelines: https://keepachangelog.com/en/1.1.0/