fix: final somatic merge #70
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
samarth8392
approved these changes
Jan 10, 2024
|
Hey @dnousome or @samarth8392, can you add a line to the changelog for this PR? Since it fixes a bug and changes how the pipeline runs, I would consider it user-facing. Keeping the changelog up to date as pull requests are merged is immensely helpful for generating release notes when it's time to release the next version. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Somatic merge across callers was not functioning correctly. Add
bcftools normacross all callers prior to mergingIssues
Fixes #69
@samarth8392
PR Checklist
(
Strikethroughany points that are not applicable.)- [ ] Update docs if there are any API changes.- [ ] UpdateCHANGELOG.mdwith a short description of any user-facing changes and reference the PR number. Guidelines: https://keepachangelog.com/en/1.1.0/