-
Notifications
You must be signed in to change notification settings - Fork 425
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[FIX] Initialize data structures for the rust CEA-708 decoder and correct Dtvcc #1618
base: master
Are you sure you want to change the base?
[FIX] Initialize data structures for the rust CEA-708 decoder and correct Dtvcc #1618
Conversation
All checkmarks are done. But with this sample file I am getting some memory leaks (in debug mode) -- error shown in here Command used: ./ccextractor ~/Downloads/cc/test_dtvcc.ts --autoprogram --out=ttxt --latin1 |
c3a9eb0
to
9493e5e
Compare
baaeadb
to
fbc8aa3
Compare
@IshanGrover2004 is this working fine now, after fixing the memory leaks? |
Working fine for some samples @PunitLodha |
fbc8aa3
to
af42011
Compare
Is there something wrong with the CI for regression test result msg? @canihavesomecoffee @prateekmedia |
ca2185d
to
e22215f
Compare
Some weeks before PR was ready. |
read consumes the dtvcc struct resulting the pointer drops immediately which we don't want
Code contains flushing the active decoders of `dtvcc_rust`
Code contains flushing the active decoders of `dtvcc_rust`
b3fcb1d
to
294b9d9
Compare
CCExtractor CI platform finished running the test files on linux. Below is a summary of the test results, when compared to test for commit 90f9f0a...:
All tests passing on the master branch were passed completely. NOTE: The following tests have been failing on the master branch as well as the PR:
Congratulations: Merging this PR would fix the following tests:
Check the result page for more info. |
CCExtractor CI platform finished running the test files on windows. Below is a summary of the test results, when compared to test for commit 98a85e1...:
All tests passing on the master branch were passed completely. NOTE: The following tests have been failing on the master branch as well as the PR:
Congratulations: Merging this PR would fix the following tests:
Check the result page for more info. |
In raising this pull request, I confirm the following (please check boxes):
My familiarity with the project is as follows (check one):
Closes #1499
Work to be done in this PR:
ccxr_dtvcc_init()
in lib.rs and use this at all places wheredtvcc_init()
is being called. (Probably add a new struct field to lib_cc_decode likedtvcc_rust
and store Dtvcc there instead of using the dtvcc field)dtvcc_free()
dec_ctx
instead of creating a new oneAdditionally to fix mp4 code flow:-