Fix #7 NC_STRING Support. #76
Conversation
|
@dnadeau4 great, what was the issue? It seems you've flaked |
|
I am still working on the "put" NC_STRING part.
Denis
…On 1/11/17 5:36 PM, Paul J. Durack wrote:
@dnadeau4 <https://github.com/dnadeau4> great, what was the issue? It
seems you've flaked |Cdunifmodule.c| so it's not easy to ascertain the fix
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#76 (comment)>, or
mute the thread
<https://github.com/notifications/unsubscribe-auth/AGnMgkmuT54IcZgAdmVsrA7rTn_xLPhzks5rRYOjgaJpZM4LhRhI>.
|
There was a problem hiding this comment.
@dnadeau4 when there are a lot of style changes it is useful to do them in a separate commit, it's eaiser to review if you do so.
|
|
||
| def tearDown(self): | ||
| super(TestNCString, self).tearDown() | ||
| #os.remove("prcp_1951.nc") |
There was a problem hiding this comment.
@dnadeau4 do you want to put that back in?
| def testNCStringWrite(self): | ||
| cdms2.setNetcdf4Flag(1) | ||
| cdms2.setNetcdfClassicFlag(0) | ||
| cdms2.setNetcdfShuffleFlag(0) |
There was a problem hiding this comment.
shouldn't cdms2.setNetcdfClassicFlag(0) be after the next 3 lines? I'm sort of remembering the next 3 turn on netcdf3 classic. But I'm not sure.
|
@doutriaux1 can you merge? Thanks! |
|
@dnadeau4 FYI, there's another issue that is occurring with the rewritten data: ncdump -h ../CMIP6/input4MIPs/UColorado/radiation/RFMIP/fx/atmos/UColorado-RFMIP-0-4/multiple/none/v20170118/multiple_input4MIPs_radiation_RFMIP_UColorado-RFMIP-0-4_none.nc | grep expt_label
string expt_label(expt) ;
expt_label:long_name = "experiment description" ;The Python 2.7.12 |Continuum Analytics, Inc.| (default, Jul 2 2016, 17:42:40)
Type "copyright", "credits" or "license" for more information.
IPython 5.1.0 -- An enhanced Interactive Python.
infile = '/work/duro/Shared/160427_CMIP6_Forcing/CMIP6/input4MIPs/UColorado/radiation/RFMIP/fx/atmos/UColorado-RFMIP-0-4/multiple/none/v20170118/multiple_input4MIPs_radiation_RFMIP_UColorado-RFMIP-0-4_none.nc'
import cdms2 as cdm
f = cdm.open(infile)
f.variables
Out[4]:
{'c2f6_GM': <cdms2.fvariable.FileVariable at 0x7f599d9c02d0>,
...
'expt_label': <cdms2.fvariable.FileVariable at 0x7f599de3ca90>,
...
'water_vapor': <cdms2.fvariable.FileVariable at 0x7f599d9c0790>}
new = f('expt_label')
Traceback (most recent call last):
File "<ipython-input-5-dc67af7a8c6f>", line 1, in <module>
new = f('expt_label')
File "/export/duro/anaconda2/envs/uvcdatNightly/lib/python2.7/site-packages/cdms2/cudsinterface.py", line 33, in __call__
return v(*args, **kwargs)
File "/export/duro/anaconda2/envs/uvcdatNightly/lib/python2.7/site-packages/cdms2/avariable.py", line 159, in __call__
grid=grid)
File "/export/duro/anaconda2/envs/uvcdatNightly/lib/python2.7/site-packages/cdms2/selectors.py", line 195, in unmodified_select
raw=raw)
File "/export/duro/anaconda2/envs/uvcdatNightly/lib/python2.7/site-packages/cdms2/avariable.py", line 776, in subRegion
return self.subSlice(*slicelist, **d)
File "/export/duro/anaconda2/envs/uvcdatNightly/lib/python2.7/site-packages/cdms2/avariable.py", line 566, in subSlice
d = self.expertSlice (slicelist)
File "/export/duro/anaconda2/envs/uvcdatNightly/lib/python2.7/site-packages/cdms2/fvariable.py", line 86, in expertSlice
result = apply(self._obj_.getitem,slist)
ValueError: data type must provide an itemsizeIs reading |
|
This one is for string attribute, I did not do the string variables yet. We should submit another issue, some people are waiting for this one to be merged. |
|
@dnadeau4 ok want me to migrate the comment above to a new issue? |
|
yes thanks! |
|
@durack1 |
|
@doutriaux1 apologies if you feel that way, what other word replacement would you prefer I use? |
|
Thanks! |
No description provided.