Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

added license moved recipe into repo #32

Merged
merged 7 commits into from
Nov 12, 2018
Merged

added license moved recipe into repo #32

merged 7 commits into from
Nov 12, 2018

Conversation

doutriaux1
Copy link
Contributor

No description provided.

@coveralls
Copy link

coveralls commented Oct 17, 2018 •
edited
Loading

Coverage Status

Coverage increased (+14.0%) to 77.047% when pulling a1d8f24 on new_license into fe08f16 on master.

@doutriaux1
Copy link
Contributor Author

@muryanto1 @dnadeau4 ping.

dnadeau4
dnadeau4 reviewed Oct 30, 2018
View reviewed changes
Copy link
Contributor

@dnadeau4 dnadeau4 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do you need a build.sh if you don't have a "C" source file?

@doutriaux1
Copy link
Contributor Author

@dnadeau4 you don't we can stick in recipe. I'm planning on doing this in another PR where I switch to setuptools and noarch but I can do it in this one if you want.

@dnadeau4
Copy link
Contributor

ok. Do you know why this is failing?

@doutriaux1
Copy link
Contributor Author

numpy 1.15 vs numpy 1.14. I will try to force 1.14 in test suite. But we should address this.

@doutriaux1
Copy link
Contributor Author

@muryanto1 @dnadeau4 ok it is ready now.

@doutriaux1 doutriaux1 merged commit 3bd6383 into master Nov 12, 2018
@doutriaux1 doutriaux1 deleted the new_license branch November 12, 2018 19:08
@doutriaux1 doutriaux1 added this to the 8.1 milestone Feb 27, 2019
@jasonb5 jasonb5 modified the milestones: 8.1, 8.2.1 Jul 27, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dnadeau4 dnadeau4 dnadeau4 approved these changes

@muryanto1 muryanto1 Awaiting requested review from muryanto1

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
8.2.1
Development

Successfully merging this pull request may close these issues.
4 participants
@doutriaux1 @coveralls @dnadeau4 @jasonb5