[WIP] Log axes 2d

[doutriaux1]

needs: #315

[doutriaux1]

@danlipsa @scottwittenburg I would like to merge this shortly in master, can you review please, it supersedes #315
Baselines are at:
CDAT/uvcdat-testdata#188

[scottwittenburg]

Whew, huge change! I mostly skimmed the parts I wasn't familiar with, but no potential issues popped out at me.

+1

[doutriaux1]

@danlipsa actually I did not do the vector or streamline graphic method. I don't quite follow the logic on how to propagate the axes to the vector arrays. I'll double check streamlines, I think I just forgot about them but if they store their own vtk copy of the data then i think it will be up to you again.

[doutriaux1]

@danlipsa might be worth merging this in first and then fix vector/streamlines separately in another PR.

[danlipsa]

What is area_wt?

[danlipsa]

@doutriaux1 Should be the same as the rest of the 2D plots, isn't it?

[danlipsa]

Looks good to me. Nice work.

[danlipsa]

Sure we can merge this and do the vectors and streamlines in a different PR.

[doutriaux1]

@danlipsa make sure you review this first though, there's a lot going on here.

[doutriaux1]

@danlipsa when I apply to vectors (area_wt on y axis) I get tiny arrows.

[danlipsa]

@doutriaux1 I have a question on axisconvert: What is the purpose of area_wt. What does wt stand for?

[danlipsa]

@doutriaux1 @aashish24 @scottwittenburg You have 'xyscale' for both axes but 'xaxisconvert' and 'yaxisconvert' for individual axes. It would be nice to make them consistent.
What about xyaxisscale, xaxisscale, yaxisscale?

[danlipsa]

We could change only xaxisconvert and yaxisconvert to xscale and yscale

[doutriaux1]

@danlipsa area_wt weights (hence the wt) the latitudes by their area, essentually it's using sine(lat).

[doutriaux1]

@danlipsa where do you see xscale and yscale?

[danlipsa]

I don't. These are the suggested new names for xaxisconvert and yaxisconvert so that they are consistent with xyscale.

[doutriaux1]

@danlipsa ok, I guess I'm wondering where do we use xyscale 😄

[danlipsa]

That's a minor issue. Grepping for xscale I can see we use that with a different meaning. Maybe:
xyaxisconvert (current name is xyscale)
xaxisconvert
yaxisconvert

[doutriaux1]

@danlipsa I see it now, there's indeed an xyscale function to set both xaxisconvert and yaxisconvert on the graphic method. I didn't even know about it! Feel free to rename the function or simply remove it, I don't it's ever used and it's really just bloatware in my opinion.