record TrandformedVariable sample #387
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sbidari
requested review from
dylanhmorris,
damonbayer and
gvegayon
as code owners
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #387 +/- ##
==========================================
+ Coverage 93.04% 93.09% +0.05%
==========================================
Files 37 37
Lines 934 941 +7
==========================================
+ Hits 869 876 +7
Misses 65 65
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
dylanhmorris
requested changes
Aug 16, 2024
dylanhmorris
previously requested changes
Aug 16, 2024
There was a problem hiding this comment.
One remaining change @sbidari. Apologies; I was unclear before.
damonbayer
reviewed
Aug 16, 2024
damonbayer
requested changes
Aug 19, 2024
There was a problem hiding this comment.
@sbidari Can you add tests to demonstrate that your naming code works as expected?
damonbayer
reviewed
Aug 19, 2024
…b.com/CDCgov/multisignal-epi-inference into 377-record-transformedrandomvariables
damonbayer
reviewed
Aug 20, 2024
…rence into 377-record-transformedrandomvariables
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #377