Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cleanup rtperiodicdiffar #419

Draft
wants to merge 2 commits into
base: main
Choose a base branch
from
Draft

Conversation

damonbayer
Copy link
Collaborator

@damonbayer damonbayer commented Aug 28, 2024

  • Renames internal variables
  • Removes RtWeeklyDiffARProcess entirely
  • Makes log_rt_init_rv, autoreg_rv, and periodic_diff_sd_rv into non-RandomVariable arguments to RtPeriodicDiffARProcess.

Copy link

codecov bot commented Aug 28, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 93.51%. Comparing base (650bf27) to head (80eb58f).

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #419      +/-   ##
==========================================
- Coverage   93.53%   93.51%   -0.03%     
==========================================
  Files          41       41              
  Lines        1021     1017       -4     
==========================================
- Hits          955      951       -4     
  Misses         66       66              
Flag Coverage Δ
unittests 93.51% <100.00%> (-0.03%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@dylanhmorris
Copy link
Collaborator

Could be good to have a test that makes use of both the vectorized differenced process and the vectorized AR process to make sure they work together. Perhaps as a test for rtperiodicdiffar. Could be done here or as part of #419

Originally posted by @damonbayer in #446 (comment)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants