Issue 183: buffering of latent delays #250
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR closes #183 by adding support for buffering in all currently supported observation models and in
LatentDelay
.I am quite unhappy about the current approach because:
LatentDelay
All that being said I think we should review this as a fix and use any major review comments in a new issue to improve this. One option we could consider is no longer support passing just
y_t = missing
and instead enforce that this must be a empty vector (and helping people achieve this). Just this change would streamline at least part of this.