Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue 183: buffering of latent delays #250

Merged
merged 3 commits into from
Jun 4, 2024
Merged

Issue 183: buffering of latent delays #250

merged 3 commits into from
Jun 4, 2024

Conversation

seabbs
Copy link
Collaborator

@seabbs seabbs commented Jun 3, 2024

This PR closes #183 by adding support for buffering in all currently supported observation models and in LatentDelay.

I am quite unhappy about the current approach because:

  • Requires support in all observation models that will be used with LatentDelay
  • Has different behaviour when completely missing a vector of missingness is passed in

All that being said I think we should review this as a fix and use any major review comments in a new issue to improve this. One option we could consider is no longer support passing just y_t = missing and instead enforce that this must be a empty vector (and helping people achieve this). Just this change would streamline at least part of this.

@seabbs seabbs requested a review from SamuelBrand1 June 3, 2024 20:59
@codecov-commenter
Copy link

codecov-commenter commented Jun 3, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 93.16%. Comparing base (1e9390b) to head (5554f74).

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #250      +/-   ##
==========================================
+ Coverage   93.07%   93.16%   +0.08%     
==========================================
  Files          43       43              
  Lines         419      424       +5     
==========================================
+ Hits          390      395       +5     
  Misses         29       29              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Collaborator

@SamuelBrand1 SamuelBrand1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good.

As a note: this PR implies redoing the underlying data generating for the pipeline (which is good and essentially what we are fixing here).

@seabbs seabbs merged commit 3a73646 into main Jun 4, 2024
10 checks passed
@seabbs seabbs deleted the issue183 branch June 4, 2024 12:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Past sequence of latent infections for initial case representation
3 participants