Issue 51: Add ascertainment_dayofweek #253
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #253 +/- ##
==========================================
- Coverage 93.07% 92.90% -0.18%
==========================================
Files 43 44 +1
Lines 419 423 +4
==========================================
+ Hits 390 393 +3
- Misses 29 30 +1 ☔ View full report in Codecov by Sentry. |
SamuelBrand1
approved these changes
Jun 4, 2024
There was a problem hiding this comment.
This looks great!
Wrt using softmax, I think that would be cool after we clear #251 e.g. we might model a weekly process but then broadcast out the weekly observations to a day of the week in a way that respects the weekly average obs.
This implementation hit a different form of modelling and looks nice!
Note: this was part of analysis plan and should now be added to pipeline.
|
I made a new issue (#258 for the |
This was referenced Jun 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR closes #51 by adding a new helper function to
EpiObsModelsthat gives semi-sensible defaults for specifying a day of the week ascertainment model (as a day of the week effect).It does this by introducing a new dependence on
EpiLatentModelsand slightly modifyingAscertainmentso that the transform has to be manually specified as vectorised (to allow for actually vectorised transforms to be supported).Note: We had discussed using a softmax but this doesn't make sense once a latent model has been broadcast. We could instead do so using a
TransformLatentModelbut to me (and as currently formulation is fairly common practice) what is here seems reasonable as a starting point.