Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove most pipeline compat and add a fetch call in testing #427

Merged
merged 2 commits into from
Aug 16, 2024

Conversation

SamuelBrand1
Copy link
Collaborator

Small PR ahead of PR to address #406 .

Informed by working on compat for EpiAware, I noted that the compat requirements in the pipeline had drifted a bit (e.g. fixing ADTypes to 1.2). My current thinking is that as a project having compat requirements for EpiAwarePipeline is not appropriate since the version of the packages used is fixed anyway.

Also, I noted that the pipeline run tests were passing before running had finished. I realised that this was because the execution was not waiting for the EagerThunk to resolve before resolving the test outcome. I've added a Dagger.fetch call to force the process to wait (this didn't change test from pass to fail but might in the future).

Copy link
Contributor

Try this Pull Request!

Open Julia and type:

import Pkg
Pkg.activate(temp=true)
Pkg.add(url="https://github.com/CDCgov/Rt-without-renewal", rev="pipeline-compat", subdir="EpiAware")
using EpiAware

@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 88.67%. Comparing base (7ed1d8e) to head (7d6a4a2).

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #427   +/-   ##
=======================================
  Coverage   88.67%   88.67%           
=======================================
  Files          56       56           
  Lines         715      715           
=======================================
  Hits          634      634           
  Misses         81       81           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@seabbs seabbs enabled auto-merge August 16, 2024 12:33
Copy link
Collaborator

@seabbs seabbs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice good spot

@seabbs seabbs added this pull request to the merge queue Aug 16, 2024
Merged via the queue into main with commit 46344f2 Aug 16, 2024
11 checks passed
@seabbs seabbs deleted the pipeline-compat branch August 16, 2024 13:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants