-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Explore using self contained pluto notebooks for documentation #437
Explore using self contained pluto notebooks for documentation #437
Conversation
Try this Pull Request!Open Julia and type: import Pkg
Pkg.activate(temp=true)
Pkg.add(url="https://github.com/CDCgov/Rt-without-renewal", rev="396-explore-using-self-contained-pluto-notebooks-for-documentation", subdir="EpiAware")
using EpiAware |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #437 +/- ##
=======================================
Coverage 89.72% 89.72%
=======================================
Files 56 56
Lines 720 720
=======================================
Hits 646 646
Misses 74 74 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I like the aim here (to make things independent). I am a little unsure we want to throw away the package manager utility.
Any help here: https://discourse.julialang.org/t/using-unregistered-packages-with-pluto/72483/4
and here: fonsp/Pluto.jl#1558
specifically Pluto.activate_notebook_environment
This seems like the ultimate solution here: fonsp/Pluto.jl#1304 (comment)
i.e. use [Source]
in Project.toml
: JuliaLang/Pkg.jl#3783
I think to get this to work you would need to manually edit the internal Project.toml of each Pluto doc (i.e. as here for the compact rec: https://discourse.julialang.org/t/update-project-toml-compat-entries-in-pluto/86396/3) which is not great but I guess will work.
Benchmark resultJudge resultBenchmark Report for /home/runner/work/Rt-without-renewal/Rt-without-renewalJob Properties
ResultsA ratio greater than
Benchmark Group ListHere's a list of all the benchmark groups executed by this job:
Julia versioninfoTarget
Baseline
Target resultBenchmark Report for /home/runner/work/Rt-without-renewal/Rt-without-renewalJob Properties
ResultsBelow is a table of this job's results, obtained by running the benchmarks.
Benchmark Group ListHere's a list of all the benchmark groups executed by this job:
Julia versioninfo
Baseline resultBenchmark Report for /home/runner/work/Rt-without-renewal/Rt-without-renewalJob Properties
ResultsBelow is a table of this job's results, obtained by running the benchmarks.
Benchmark Group ListHere's a list of all the benchmark groups executed by this job:
Julia versioninfo
Runtime information
|
…ooks-for-documentation
Benchmark resultJudge resultBenchmark Report for /home/runner/work/Rt-without-renewal/Rt-without-renewalJob Properties
ResultsA ratio greater than
Benchmark Group ListHere's a list of all the benchmark groups executed by this job:
Julia versioninfoTarget
Baseline
Target resultBenchmark Report for /home/runner/work/Rt-without-renewal/Rt-without-renewalJob Properties
ResultsBelow is a table of this job's results, obtained by running the benchmarks.
Benchmark Group ListHere's a list of all the benchmark groups executed by this job:
Julia versioninfo
Baseline resultBenchmark Report for /home/runner/work/Rt-without-renewal/Rt-without-renewalJob Properties
ResultsBelow is a table of this job's results, obtained by running the benchmarks.
Benchmark Group ListHere's a list of all the benchmark groups executed by this job:
Julia versioninfo
Runtime information
|
Shall we close this PR as I think we agree the correct approach is to use source? Using:
Or shall we update doing this? I think this still leaves an issue in that it won't just work for people so potentially we want to regex in the source URL vs using a relative path (so that the pluto truely stands alone). |
Agreed. |
A draft PR exploring the use of self contained Pluto notebooks.